Fix screen reader issues with CardAction/Button/MenuItem/NavigationViewItem #1235
+205
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
Difegue
changed the title
Difegue
force-pushed
the
narration-fixes
branch
from
7f685c7 to
4491fa1
Compare
pomianowski
approved these changes
Feb 1, 2025
pomianowski
pushed a commit
that referenced
this pull request
Feb 1, 2025
…ewItem (#1235) * Add narration support to CardAction * Fix screen readers trying to read IconElement in some cases * Add narration support to NavigationViewItem * Button workaround appears to be unnecessary now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Screen Readers will try to narrate the Icon for Buttons and MenuItems if they have them set.
Additionally, CardAction and NavigationViewItem have no screen reader support whatsoever.
Issue Number: N/A
What is the new behavior?
Other information